IBX-9941: Fixed minor issues after schema rebranding #552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…::loadBookmark query
alongosz
force-pushed
the
ibx-9941-post-merge-improvements
branch
from
d0e2e20 to
cc986d7
Compare
adamwojs
reviewed
May 29, 2025
src/lib/Persistence/Legacy/Content/ObjectState/Gateway/DoctrineDatabase.php
Outdated
Show resolved
Hide resolved
alongosz
force-pushed
the
ibx-9941-post-merge-improvements
branch
from
cc986d7 to
b38e649
Compare
|
ezrobot
requested review from
Steveb-p,
ViniTou,
adamwojs,
barw4,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
konradoboza
approved these changes
May 30, 2025
adamwojs
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
I finally managed to finish the review of #541 (better late than never, right? ;-))
I found some minor things, mostly nitpicks, that can be improved:
ezbinaryfile.yamltoibexa_binary_file.yaml@coversvalue for Bookmark GW DoctrineDatabaseTest*- µ-optimization ofc, but was looking at the file anyway)@coversvalue for Content GW DoctrineDatabaseTestFor QA:
No QA required.